Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for ramen #357

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream main branch

k8s.io/component-base should have been a direct dependency.
Fixes the go mod error.

Signed-off-by: Raghavendra Talur <[email protected]>
- Integrated the latest CRD from external-snapshotter.
- Updated dependencies and relevant configuration files.
- Changed VolumeSnapshotRefList in VolumeGroupSnapshotStatus to PVCVolumeSnapshotRefList,
which allows to map a VolumeSnapshot to the application PVC.

Signed-off-by: Benamar Mekhissi <[email protected]>
This is mainly to ensure that the VRG on the primary and secondary are in sync
in regards to labels and annotations

Signed-off-by: Benamar Mekhissi <[email protected]>
* Allow unprivileged pods to access block devices

We need this for testing volsync with block devices with minikube
clusters.

For minikube clusters this is done via the environment file which is
nicer, but it requires configuring containerd after the cluster has
started, which can cause failures in addons scripts.

We need to upstream this change to minikube later.

Signed-off-by: Nir Soffer <[email protected]>

* Log replication source status in yaml

It is easier to read and works better for viewing the replication logs
in the status.

Signed-off-by: Nir Soffer <[email protected]>

* Improve volsync test teardown

- Delete the replication source before unexporting the volsync service
  using it.
- Log every every teardown step to make debugging easier.

Signed-off-by: Nir Soffer <[email protected]>

* Fail if deleting destination namespace get stuck

Replace delete used for waiting for waiting on the deleted namespace
with a timeout. If deletion get stuck, the test will fail instead of
blocking forever, breaking stress test.

When delete get suck we can inspect the resources in the test gather
directory:

    % tree out/013.gather/dr2/namespaces/busybox
    out/013.gather/dr2/namespaces/busybox
    └── snapshot.storage.k8s.io
        └── volumesnapshots
            └── volsync-busybox-dst-dst-20240914203905.yaml

    % cat out/013.gather/dr2/namespaces/busybox/snapshot.storage.k8s.io/volumesnapshots/volsync-busybox-dst-dst-20240914203905.yaml
    apiVersion: snapshot.storage.k8s.io/v1
    kind: VolumeSnapshot
    metadata:
      creationTimestamp: "2024-09-14T20:39:05Z"
      deletionGracePeriodSeconds: 0
      deletionTimestamp: "2024-09-14T20:39:05Z"
      finalizers:
      - snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
      generation: 2

This looks like an external-snapshotter bug since volsync deleted the
snapshot and removed its finalizers.

Signed-off-by: Nir Soffer <[email protected]>

---------

Signed-off-by: Nir Soffer <[email protected]>
@df-build-team df-build-team requested a review from a team September 18, 2024 08:01
Copy link

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: df-build-team

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ShyamsundarR ShyamsundarR merged commit 6e8539a into main Sep 18, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants